Randomly generated IDs #931
Conversation
| } | ||
|
|
||
| #[derive(Args, Clone, Debug)] | ||
| pub struct HostCli { |
There was a problem hiding this comment.
I'm assuming this one is left here because of the hurdles.
There was a problem hiding this comment.
Yeah, that's just the common args for the commands that host (run, serve). Can't do much about that, I think.
|
|
||
| #[derive(Parser, Clone, Debug)] | ||
| /// Builds and runs the package locally | ||
| pub struct Run { |
There was a problem hiding this comment.
So the idea is for run to be under package? ambient package run?
There was a problem hiding this comment.
The idea was that I'd move all the commands there, and then have aliases back to them, as-is the case with campfire - so that you could always have a consistent interface, but also a convenient one. However, didn't happen, so it's still just ambient run.
| ALPHABET[idx - NUMERALS.len()] | ||
| }; | ||
| // TODO: see if there's a more intelligent way to ensure the first character | ||
| // is always alphabetic |
There was a problem hiding this comment.
The comparison was not lost on me and it makes me sad 😂
|
Waiting for #961 to go in, then merging |
|
Worth retesting #909 if the CLI code changed. |
|
I think that issue is with the version-manager-CLI, not the Ambient CLI (yes this is confusing, see AmbientRun/AmbientCli#3) |
Closes #679, closes #921.
The code for the CLI was rearranged because my initial plan was to move all of the package commands into a
packagesubcommand, and then set up top-level aliases, but I ran into a few hurdles and decided to leave it as-is for now.I won't automerge this until I have signoff from the reviewers because I suspect we'll want to wipe the database before we do.