Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renovate the build gradle file and transfer the plugin.yml into it #142

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

TheMeinerLP
Copy link

@TheMeinerLP TheMeinerLP commented Feb 6, 2024

Overview

This pull requests don't target at a issue.

Problem

It is very difficult to read the original Gradle file because it has some things that make no sense for such a small project

Description

This renovate the build gradle file to improve for other developers the readbility. Also transfer the plugin.yml into it with the gradle plugin of Minecrell thats add the option for plugin.yml generation. In that sense it reduce some small lines of code.
Its sorts some content in to more clear order also setup up the Java version 17 and uses the newer options of gradle for it.

Checklist

  • I included all information required in the sections above
  • I tested my changes and approved their functionality
  • I ensured my changes do not break other parts of the code

This commit transfers the plugin.yml into the build.gradle.kts and clean up the build file in sense of sorting the content and remove or replace some code with newer one. Also bumps the paper version to 1.20.4.
build.gradle.kts Show resolved Hide resolved
build.gradle.kts Outdated Show resolved Hide resolved
@NotMyFault
Copy link
Member

The code restored is incorrect to the code removed. The toolchain should point to Java 17 as development goal but compile against Java 8 as release goal.

The code removed hasn't been restored correctly, TARGET_JVM_VERSION_ATTRIBUTE is still missing, causing a failure in GH actions.

16436bd (#142) is incorrect still. Instead of restoring the previous removed TARGET_JVM_VERSION_ATTRIBUTE field, you modified another entry irrelevant to the former one.

If TARGET_JVM_VERSION_ATTRIBUTE is not added back in the same spot you removed it from, the build will continue to fail.

@TheMeinerLP
Copy link
Author

What is the big difference between TARGET_JVM_VERSION_ATTRIBUTE and the current code?

@NotMyFault
Copy link
Member

What is the big difference between TARGET_JVM_VERSION_ATTRIBUTE and the current code?

targetCompatibility and sourceCompatibility represent the javac flags -target release and -source release.
TARGET_JVM_VERSION_ATTRIBUTE is an attribute for Gradle.

All three options serve different purposes and don't build upon each other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants