-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added coverage annotations filters #410
Conversation
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success168 tests passing in 57 suites. Report generated by 🧪jest coverage report action from 7fba574 |
Actually I see the coverage for |
Fair enough, I'll mark it as ready then :)
This issue comes with any service that allows for customisation. I've allowed by default all the annotations so that existing users will not have to worry about mentioning anything - I still believe that a filter option would be nice to have, as long as the user understands its implications. Perhaps at some point it could be worth looking into comments as well, but for now this would bring us a lot of value (: |
Yeah, I understand that it is a good fix to reduce loudness. But my point is - maybe uncovered line annotations will suit your needs? I just don't want to add a new feature, that is likely to be deprecated once uncovered line annotations will land. I believe, that user expects to see which lines are not covered, not statements/branches/functions. |
It is fair - in the end it's your repo and it's up to you if you want to introduce the feature or not :). In my mind this is not a enforced change but a possibility to make it more customisable to fit our specific use case. Let me know if I should close the PR :) |
Hi there @ArtiomTr, hope it's alright I open a PR here.
We tried using your action and found it a bit loud. For five lines of code it managed to produce an equal amount of annotations. I've tried to pull out a way to filter out some of these, also updated some of your tests to match the new implementation.
Let me know if I missed anything :)