🚧 Split luminol into separate crates #45
Conversation
The Rust documentation says you need to enable the write flag to use create or truncate when writing to files, so using the create flag without also using the write flag is probably undefined behaviour. It seems there are still more problems preventing saving from working, but I assume this is in the scope of Astrabit-ST#45 so I will make no further changes.
The Rust documentation says you need to enable the write flag to use create or truncate when writing to files, so using the create flag without also using the write flag is probably undefined behaviour. It seems there are still more problems preventing saving from working, but I assume this is in the scope of #45 so I will make no further changes.
melody-rs
force-pushed
the
split-crates
branch
from
e3c47a0 to
a2883df
Compare
|
Does the map editor work in web builds yet? When I try opening the map editor I start getting WebGPU errors and the screen turns blank. |
|
It did before, I'm not sure why that's happening? I have a sneaking suspicion it has something to do with I was going to pull in naga_oil to replace the const_format stuff in a separate PR but I'll try it now and see what happens |
|
@white-axe Should be fixed now! |
There was a problem hiding this comment.
In my opinion, luminol- prefix should be omitted in the crates directory. The fact that they belong to Luminol is self-explanatory because of the root package manifest and git repository these crates are in.
i.e.
crates
└ ━> app
└ ━> audio
└ ━> components
└ ━> [...]
|
Ok, I'll do that! I'll still keep the prefix in the crate names though to avoid collision with module names and because I intend to upload luminol to crates.io in the future. |
This is currently WIP. The goal of this PR is to split Luminol into separate crates and ditch interior mutability, hopefully solving a whole class of bugs related to opening and closing projects.