Fix an issue that DirtyRects are full region every frame. #16849
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR #14924 add a field
_fullRedrawRequested
to force the dirty rects to be ignored and redraw the whole window. After that, the rendering performance becomes poor. By the test on my machine, the fps drops from 45 to 30.I can't figure out why this field is introduced. There is no description about this field in the PR !14924 nor in the comments. So I'm trying to remove the assignment and fix the dirty rects.
The previous PR:
What is the current behavior?
See this video below to view the dirty rect changes before and after this PR.
What is the updated/expected behavior with this PR?
DirtyRectsAlwaysFull.mp4
How was the solution implemented (if it's not obvious)?
Remove the assignment of the
_fullRedrawRequested
field.Checklist
Breaking changes
To be discussed.
Obsoletions / Deprecations
Fixed issues