Update datatemplates.md #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to indicate the other datype or the code will not compile
maxkatz6
reviewed
Aug 27, 2023
| @@ -22,7 +22,7 @@ For example, this code adds a data template to display the view model class `MyV | |||
| <!-- Assuming that DataContext.Foo is an object of type | |||
| MyApp.ViewModels.FooViewModel then a red border with a corner | |||
| radius of 8 containing a TextBox will be displayed here --> | |||
| <ContentControl Content="{Binding Foo}"/> | |||
| <ContentControl DataType="viewmodels:UserControl1ViewModel" Content="{Binding Foo}"/> | |||
There was a problem hiding this comment.
UserControl1ViewModel is not mentioned anywhere on this page, and is a bit confusing.
Also, it would make more sense to add DataType on the top-level element here - UserControl.
maxkatz6
approved these changes
Nov 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to indicate the other datype or the code will not compile