[Fabric E2E Sample] Improving README.md (#1081)

* Improving README and know issues markdown files
Azure-Samples · Feb 10, 2025 · ef260f3 · ef260f3
1 parent 227865f
commit ef260f3
Show file tree

Hide file tree

Showing 18 changed files with 348 additions and 156 deletions.
diff --git a/e2e_samples/fabric_dataops_sample/README.md b/e2e_samples/fabric_dataops_sample/README.md
diff --git a/e2e_samples/fabric_dataops_sample/docs/issues_limitations_and_workarounds.md b/e2e_samples/fabric_dataops_sample/docs/issues_limitations_and_workarounds.md
diff --git a/e2e_samples/fabric_dataops_sample/docs/known_issues_limitations_and_faqs.md b/e2e_samples/fabric_dataops_sample/docs/known_issues_limitations_and_faqs.md
diff --git a/e2e_samples/fabric_dataops_sample/images/application-enterprise-object-id.png b/e2e_samples/fabric_dataops_sample/images/application-enterprise-object-id.png
diff --git a/e2e_samples/fabric_dataops_sample/images/branch-out-to-new-workspace.gif b/e2e_samples/fabric_dataops_sample/images/branch-out-to-new-workspace.gif
diff --git a/e2e_samples/fabric_dataops_sample/images/create-pr.gif b/e2e_samples/fabric_dataops_sample/images/create-pr.gif
diff --git a/e2e_samples/fabric_dataops_sample/images/creating-onelake-shortcut.gif b/e2e_samples/fabric_dataops_sample/images/creating-onelake-shortcut.gif
diff --git a/e2e_samples/fabric_dataops_sample/images/dev-container.png b/e2e_samples/fabric_dataops_sample/images/dev-container.png
diff --git a/e2e_samples/fabric_dataops_sample/images/make-workspace-changes.gif b/e2e_samples/fabric_dataops_sample/images/make-workspace-changes.gif
diff --git a/e2e_samples/fabric_dataops_sample/images/missing-lakehouse-environment.png b/e2e_samples/fabric_dataops_sample/images/missing-lakehouse-environment.png
diff --git a/e2e_samples/fabric_dataops_sample/images/pipeline-interactive-login.png b/e2e_samples/fabric_dataops_sample/images/pipeline-interactive-login.png
diff --git a/e2e_samples/fabric_dataops_sample/images/published-artifacts.gif b/e2e_samples/fabric_dataops_sample/images/published-artifacts.gif
diff --git a/e2e_samples/fabric_dataops_sample/images/storage-error.png b/e2e_samples/fabric_dataops_sample/images/storage-error.png
diff --git a/e2e_samples/fabric_dataops_sample/images/trigger-cleanup-pipeline.gif b/e2e_samples/fabric_dataops_sample/images/trigger-cleanup-pipeline.gif
diff --git a/e2e_samples/fabric_dataops_sample/images/uncommitted-environment.gif b/e2e_samples/fabric_dataops_sample/images/uncommitted-environment.gif
diff --git a/e2e_samples/fabric_dataops_sample/prepare_azure_repo.sh b/e2e_samples/fabric_dataops_sample/prepare_azure_repo.sh
@@ -54,19 +54,17 @@ for i in "${!ENVIRONMENT_NAMES[@]}"; do
   placeholder_service_connection_name="<ENV${index}_SERVICE_CONNECTION_NAME>"
 
   # Replace placeholders in the pipeline files
-  if [[ "$OSTYPE" == "darwin"* ]]; then
-    replace "$placeholder_branch_name" "$azdo_git_branch_name" "$ci_artifacts_pipeline"
-    replace "$placeholder_variable_group_name" "$azdo_variable_group_name" "$ci_artifacts_pipeline"
-    replace "$placeholder_service_connection_name" "$azdo_service_connection_name" "$ci_artifacts_pipeline"
+  replace "$placeholder_branch_name" "$azdo_git_branch_name" "$ci_artifacts_pipeline"
+  replace "$placeholder_variable_group_name" "$azdo_variable_group_name" "$ci_artifacts_pipeline"
+  replace "$placeholder_service_connection_name" "$azdo_service_connection_name" "$ci_artifacts_pipeline"
 
-    replace "$placeholder_branch_name" "$azdo_git_branch_name" "$ci_qa_cleanup_pipeline"
-    replace "$placeholder_variable_group_name" "$azdo_variable_group_name" "$ci_qa_cleanup_pipeline"
-    replace "$placeholder_service_connection_name" "$azdo_service_connection_name" "$ci_qa_cleanup_pipeline"
+  replace "$placeholder_branch_name" "$azdo_git_branch_name" "$ci_qa_cleanup_pipeline"
+  replace "$placeholder_variable_group_name" "$azdo_variable_group_name" "$ci_qa_cleanup_pipeline"
+  replace "$placeholder_service_connection_name" "$azdo_service_connection_name" "$ci_qa_cleanup_pipeline"
 
-    replace "$placeholder_branch_name" "$azdo_git_branch_name" "$ci_qa_pipeline"
-    replace "$placeholder_variable_group_name" "$azdo_variable_group_name" "$ci_qa_pipeline"
-    replace "$placeholder_service_connection_name" "$azdo_service_connection_name" "$ci_qa_pipeline"
-  fi
+  replace "$placeholder_branch_name" "$azdo_git_branch_name" "$ci_qa_pipeline"
+  replace "$placeholder_variable_group_name" "$azdo_variable_group_name" "$ci_qa_pipeline"
+  replace "$placeholder_service_connection_name" "$azdo_service_connection_name" "$ci_qa_pipeline"
 done
 
 echo "[Info] ############    AZDO PIPELINE FILES CREATED   ############"

diff --git a/e2e_samples/fabric_dataops_sample/scripts/cleanup_infrastructure.sh b/e2e_samples/fabric_dataops_sample/scripts/cleanup_infrastructure.sh
@@ -78,10 +78,8 @@ cleanup_terraform_resources() {
 
   if [[ -z ${existing_fabric_capacity_name} ]]; then
     create_fabric_capacity=true
-    echo "[Info] Variable 'EXISTING_FABRIC_CAPACITY_NAME' is empty, a new Fabric capacity will be created."
   else
     create_fabric_capacity=false
-    echo "[Info] Variable 'EXISTING_FABRIC_CAPACITY_NAME' is NOT empty, the provided Fabric capacity will be used."
   fi
 
   echo "[Info] Switching to terraform '$environment_name' workspace."

diff --git a/e2e_samples/fabric_dataops_sample/scripts/deploy_azdo_pipelines.sh b/e2e_samples/fabric_dataops_sample/scripts/deploy_azdo_pipelines.sh
@@ -165,11 +165,11 @@ create_azdo_branch_policy () {
   echo "[Info] Build policy created/updated successfully."
 }
 
-validate_env_vars
-
 echo "[Info] ############ CREATING AZDO PIPELINES  ############"
 set_global_azdo_config
 
+validate_env_vars
+
 create_azdo_pipeline \
   "$azdo_pipeline_ci_qa" \
   "$AZDO_PIPELINES_BRANCH_NAME" \