Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change getActiveAccount to be getAllAccounts #83

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jade-codes
Copy link

Purpose

When using the sample, I noticed a small error with the original sample. In the example there is a section that says you should set the active account by doing the following:

getActiveAccount()[0]

This wouldn't make sense since why would you be setting active account by getting the first active account if getActiveAccount() is false? I believe this is erroneous and should be getAllAccounts() based on the logic.

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

@nivethan-dev
Copy link

+1

@langley-enduir
Copy link

Something of note... I used this sample code and everything ran perfectly when run locally and hosted via S3/CF until I changed my deployment structure to multiapp. That is when this code began to fail. I made the exact change suggested by this PR and it worked again.

So I can verify that this fix works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants