Change getActiveAccount to be getAllAccounts #83
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When using the sample, I noticed a small error with the original sample. In the example there is a section that says you should set the active account by doing the following:
getActiveAccount()[0]
This wouldn't make sense since why would you be setting active account by getting the first active account if
getActiveAccount()
is false? I believe this is erroneous and should begetAllAccounts()
based on the logic.Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?