Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registered DeID service to to network module #30627

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

chrisribe
Copy link
Member

@chrisribe chrisribe commented Jan 8, 2025

Related commands

  • az network private-link-resource list --name {serviceName} --resource-group {rg} --type Microsoft.HealthDataAiservices/deidservices
  • az network private-endpoint-connection list --name {serviceName} -g {rg} --type Microsoft.HealthDataAiservices/deidservices
  • az network private-endpoint-connection delete --name {pe_connection_name} -g {rg} --resource-name {serviceName} --type Microsoft.HealthDataAiservices/deidservices -y

Description

Registered DeID service to to network module and created proper test cases + live recordings

Testing Guide
See NetworkPrivateLinkDeidServiceScenarioTest in test_private_endpoint_commands.py

azdev test NetworkPrivateLinkDeidServiceScenarioTest

History Notes


This checklist is used to make sure that common guidelines for a pull request are followed.

Copy link

Validation for Azure CLI Full Test Starting...

Thanks for your contribution!

Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

@yonzhan
Copy link
Collaborator

yonzhan commented Jan 8, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Auto-Assign Auto assign by bot label Jan 8, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Network az network vnet/lb/nic/dns/etc... label Jan 8, 2025
@chrisribe
Copy link
Member Author

Any updates on this PR ?

@chrisribe
Copy link
Member Author

Hi @necusjz,

I hope you're doing well. I just wanted to check in and see if anyone has had a chance to review my pull request.
I want to make sure it doesn't get overlooked.
Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot Network az network vnet/lb/nic/dns/etc...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants