Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BULK] - DocuTune remediation - Sensitive terms with GUIDs (part 9) #1027

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

meganbradley
Copy link
Contributor

Applying sensitive terms with GUID changes as part of Content SFI and outlined in Overview - Writing content securely - Platform Manual. Changes are part of the Microsoft-wide SFI effort. Point of contact: @CelesteDG

DocuTune v1.5.2.0
CorrelationId: ac15aa43-4e2b-437f-ab1c-fdd7e79cd4db

#docutune

@meganbradley
Copy link
Contributor Author

#docutune-review

Copy link
Contributor

Learn Build status updates of commit 9fff66f:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
azureadps-2.0/AzureAD/migrate/New-AzureADUser.md ❌Error Details

azureadps-2.0/AzureAD/migrate/New-AzureADUser.md

  • Line 28, Column 1: [Error: include-not-found - See documentation] Invalid include link: '~/graphref/api-reference/v1.0/includes/permissions/user-post-users-permissions.md'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@msewaweru
Copy link
Collaborator

Trigger rebuild.

@msewaweru msewaweru closed this Oct 22, 2024
@msewaweru msewaweru reopened this Oct 22, 2024
Copy link
Contributor

Learn Build status updates of commit 9fff66f:

✅ Validation status: passed

File Status Preview URL Details
azureadps-2.0-preview/AzureAD/Remove-AzureADMSApplicationKey.yml ✅Succeeded
azureadps-2.0-preview/AzureAD/Remove-AzureADMSApplicationOwner.md ✅Succeeded View (azureadps-2.0-preview)
azureadps-2.0-preview/AzureAD/Remove-AzureADMSApplicationOwner.yml ✅Succeeded
azureadps-2.0-preview/AzureAD/Remove-AzureADMSApplicationPassword.md ✅Succeeded View (azureadps-2.0-preview)
azureadps-2.0-preview/AzureAD/Remove-AzureADMSApplicationPassword.yml ✅Succeeded
azureadps-2.0-preview/AzureAD/Remove-AzureADMSConditionalAccessPolicy.md ✅Succeeded View (azureadps-2.0-preview)
azureadps-2.0-preview/AzureAD/Remove-AzureADMSConditionalAccessPolicy.yml ✅Succeeded
azureadps-2.0-preview/AzureAD/Remove-AzureADMSFeatureRolloutPolicyDirectoryObject.md ✅Succeeded View (azureadps-2.0-preview)
azureadps-2.0-preview/AzureAD/Remove-AzureADMSFeatureRolloutPolicyDirectoryObject.yml ✅Succeeded
azureadps-2.0-preview/AzureAD/Remove-AzureADMSNamedLocationPolicy.md ✅Succeeded View (azureadps-2.0-preview)
azureadps-2.0-preview/AzureAD/Remove-AzureADMSNamedLocationPolicy.yml ✅Succeeded
azureadps-2.0-preview/AzureAD/Remove-AzureADMSPasswordSingleSignOnCredential.md ✅Succeeded View (azureadps-2.0-preview)
azureadps-2.0-preview/AzureAD/Remove-AzureADMSPasswordSingleSignOnCredential.yml ✅Succeeded
azureadps-2.0-preview/AzureAD/Remove-AzureADMSPermissionGrantConditionSet.md ✅Succeeded View (azureadps-2.0-preview)
azureadps-2.0-preview/AzureAD/Remove-AzureADMSPermissionGrantConditionSet.yml ✅Succeeded
azureadps-2.0-preview/AzureAD/Restore-AzureADDeletedApplication.md ✅Succeeded View (azureadps-2.0-preview)
azureadps-2.0-preview/AzureAD/Restore-AzureADDeletedApplication.yml ✅Succeeded
azureadps-2.0-preview/AzureAD/Revoke-AzureADUserAllRefreshToken.md ✅Succeeded View (azureadps-2.0-preview)
azureadps-2.0-preview/AzureAD/Revoke-AzureADUserAllRefreshToken.yml ✅Succeeded
azureadps-2.0-preview/AzureAD/Set-AzureADApplication.md ✅Succeeded View (azureadps-2.0-preview)

For more details, please refer to the build report.

For any questions, please:

Copy link
Collaborator

@msewaweru msewaweru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested.

@@ -11,7 +11,7 @@ syntaxes:
examples:
- title: 'Example 1: Removes a key credential from an application'
code: |-
PS C:\>Remove-AzureADMSApplicationKey -ObjectId "3ddd22e7-a150-4bb3-b100-e410dea1cb84" -KeyId "FDA27CF-1B58-4CAE-8CE7-CD04F0AAB945" -Proof {token}
PS C:\>Remove-AzureADMSApplicationKey -ObjectId "aaaaaaaa-0000-1111-2222-bbbbbbbbbbbb" -KeyId "FDA27CF-1B58-4CAE-8CE7-CD04F0AAB945" -Proof {token}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Key ID GUID not updated.

@@ -26,7 +26,7 @@ federation).

### Example 1: Removes a group from the cloud authentication roll-out policy from Azure AD.
```
PS C:\> Remove-AzureADMSFeatureRolloutPolicyDirectoryObject -Id "a03b6d9e-6654-46e6-8d0a-8ed83c675ca9" -ObjectId "0a1068c0-dbb6-4537-9db3-b48f3e31dd76"
PS C:\> Remove-AzureADMSFeatureRolloutPolicyDirectoryObject -Id "a03b6d9e-6654-46e6-8d0a-8ed83c675ca9" -ObjectId "aaaaaaaa-0000-1111-2222-bbbbbbbbbbbb"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Id GUID here hasn't been updated.

@@ -9,7 +9,7 @@ syntaxes:
examples:
- title: 'Example 1: Removes a group from the cloud authentication roll-out policy from Azure AD.'
code: |-
PS C:\> Remove-AzureADMSFeatureRolloutPolicyDirectoryObject -Id "a03b6d9e-6654-46e6-8d0a-8ed83c675ca9" -ObjectId "0a1068c0-dbb6-4537-9db3-b48f3e31dd76"
PS C:\> Remove-AzureADMSFeatureRolloutPolicyDirectoryObject -Id "a03b6d9e-6654-46e6-8d0a-8ed83c675ca9" -ObjectId "aaaaaaaa-0000-1111-2222-bbbbbbbbbbbb"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as previous comment.

@@ -33,26 +33,26 @@ ObjectId AppId Displa
421c3f21-22b1-43ea-b438-f00bcad54bd7 f9009add-63a4-4231-9532-9bdc22742922 PowerShellGraphAPI
4862738f-9ce9-4db6-ab55-e185049f4597 d961ff63-d659-42d5-8ca8-908b3bbb79cb WingTips
49a8bc01-2751-450b-a2e8-b4267f609513 10d861e6-90b3-4854-a504-f656aab2a14e AzurePopulator
79592454-dea7-4660-9d91-f1768e5055ac feabcdd1-711a-4d55-ad5e-0d0577aaaa5e analog
aaaaaaaa-0000-1111-2222-bbbbbbbbbbbb feabcdd1-711a-4d55-ad5e-0d0577aaaa5e analog
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other real GUIDs have not been updated.

@@ -24,26 +24,26 @@ examples:
421c3f21-22b1-43ea-b438-f00bcad54bd7 f9009add-63a4-4231-9532-9bdc22742922 PowerShellGraphAPI
4862738f-9ce9-4db6-ab55-e185049f4597 d961ff63-d659-42d5-8ca8-908b3bbb79cb WingTips
49a8bc01-2751-450b-a2e8-b4267f609513 10d861e6-90b3-4854-a504-f656aab2a14e AzurePopulator
79592454-dea7-4660-9d91-f1768e5055ac feabcdd1-711a-4d55-ad5e-0d0577aaaa5e analog
aaaaaaaa-0000-1111-2222-bbbbbbbbbbbb feabcdd1-711a-4d55-ad5e-0d0577aaaa5e analog
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not all GUIDs have been updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants