Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Corehttp] Add model attribute to HttpResponseError #39636

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

pvaneck
Copy link
Member

@pvaneck pvaneck commented Feb 8, 2025

Description

This added a model instance attribute to HttpResponseError.

Closes: #38956

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@pvaneck pvaneck force-pushed the corehttp-error-model branch from 86a5003 to d96f7af Compare February 8, 2025 03:04
@pvaneck pvaneck marked this pull request as ready for review February 12, 2025 22:59
@pvaneck pvaneck merged commit a8ded42 into Azure:main Feb 13, 2025
43 checks passed
@pvaneck pvaneck deleted the corehttp-error-model branch February 13, 2025 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[corehttp] HttpResponseError lacks kwargs signature model compared with same class of azure-core
3 participants