Skip to content

Commit

Permalink
rename command bar feature flag
Browse files Browse the repository at this point in the history
  • Loading branch information
analogrelay committed Aug 13, 2024
1 parent 01c6b60 commit f08455f
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ export function createStaticCommandBarButtons(
selectedCollection && selectedCollection.onNewStoredProcedureClick(selectedCollection);
},
commandButtonLabel: label,
tooltipText: userContext.features.enableCommandBarRedesign ? "New..." : label,
tooltipText: userContext.features.commandBarV2 ? "New..." : label,
ariaLabel: label,
hasPopup: true,
disabled:
Expand Down Expand Up @@ -405,7 +405,7 @@ function createOpenQueryButton(): CommandButtonComponentProps {
return {
iconSrc: BrowseQueriesIcon,
iconAlt: label,
tooltipText: userContext.features.enableCommandBarRedesign ? "Open Query..." : "Open Query",
tooltipText: userContext.features.commandBarV2 ? "Open Query..." : "Open Query",
keyboardAction: KeyboardAction.OPEN_QUERY,
onCommandClick: (_, container) =>
useSidePanel.getState().openSidePanel("Open Saved Queries", <BrowseQueriesPane explorer={container} />),
Expand Down
2 changes: 1 addition & 1 deletion src/Explorer/Tabs/Tabs.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ export const Tabs = ({ explorer }: TabsProps): JSX.Element => {
</ul>
</div>
<div className="tabPanesContainer">
{userContext.features.enableCommandBarRedesign && <CommandBarV2 explorer={explorer} />}
{userContext.features.commandBarV2 && <CommandBarV2 explorer={explorer} />}
{activeReactTab !== undefined && getReactTabContent(activeReactTab, explorer)}
{openedTabs.map((tab) => (
<TabPane key={tab.tabId} tab={tab} active={activeTab === tab} />
Expand Down
2 changes: 1 addition & 1 deletion src/Main.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ const App: React.FunctionComponent = () => {
<div id="divExplorer" className="flexContainer hideOverflows">
<div id="freeTierTeachingBubble"> </div>
{/* Main Command Bar - Start */}
{!userContext.features.enableCommandBarRedesign && <CommandBar container={explorer} />}
{!userContext.features.commandBarV2 && <CommandBar container={explorer} />}
{/* Collections Tree and Tabs - Begin */}
<SidebarContainer explorer={explorer} />
{/* Collections Tree and Tabs - End */}
Expand Down
4 changes: 2 additions & 2 deletions src/Platform/Hosted/extractFeatures.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export type Features = {
readonly copilotChatFixedMonacoEditorHeight: boolean;
readonly enablePriorityBasedExecution: boolean;
readonly disableConnectionStringLogin: boolean;
readonly enableCommandBarRedesign: boolean;
readonly commandBarV2: boolean;

// can be set via both flight and feature flag
autoscaleDefault: boolean;
Expand Down Expand Up @@ -109,7 +109,7 @@ export function extractFeatures(given = new URLSearchParams(window.location.sear
copilotChatFixedMonacoEditorHeight: "true" === get("copilotchatfixedmonacoeditorheight"),
enablePriorityBasedExecution: "true" === get("enableprioritybasedexecution"),
disableConnectionStringLogin: "true" === get("disableconnectionstringlogin"),
enableCommandBarRedesign: "true" === get("enablecommandbarredesign"),
commandBarV2: "true" === get("commandbarv2"),
};
}

Expand Down

0 comments on commit f08455f

Please sign in to comment.