Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Most Recent activity local storage to App State persistence #1967

Merged
merged 7 commits into from
Sep 20, 2024
Merged

Migrate Most Recent activity local storage to App State persistence #1967

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ee91467
Rewrite MostRecentActivity to leverage AppStatePersistenceUtility.
languy Sep 4, 2024
2679423
Fix format. Update type enum.
languy Sep 12, 2024
673a8ba
Migrate Item enum to string enum
languy Sep 12, 2024
a3f1328
Merge branch 'master' into users/languye/migrate-mostrecent-to-new-st…
languy Sep 12, 2024
586f9f9
Fix unit tests
languy Sep 12, 2024
ffcbc59
Fix build issue
languy Sep 12, 2024
02b2cf3
Merge branch 'master' into users/languye/migrate-mostrecent-to-new-st…
languy Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 23 additions & 57 deletions src/Explorer/MostRecentActivity/MostRecentActivity.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
import { clear, collectionWasOpened, getItems, Type } from "Explorer/MostRecentActivity/MostRecentActivity";
import { observable } from "knockout";
import { mostRecentActivity } from "./MostRecentActivity";

describe("MostRecentActivity", () => {
const accountId = "some account";
const accountName = "some account";

beforeEach(() => mostRecentActivity.clear(accountId));
beforeEach(() => clear(accountName));

it("Has no items at first", () => {
expect(mostRecentActivity.getItems(accountId)).toStrictEqual([]);
expect(getItems(accountName)).toStrictEqual([]);
});

it("Can record collections being opened", () => {
Expand All @@ -18,9 +18,9 @@ describe("MostRecentActivity", () => {
databaseId,
};

mostRecentActivity.collectionWasOpened(accountId, collection);
collectionWasOpened(accountName, collection);

const activity = mostRecentActivity.getItems(accountId);
const activity = getItems(accountName);
expect(activity).toEqual([
expect.objectContaining({
collectionId,
Expand All @@ -29,58 +29,24 @@ describe("MostRecentActivity", () => {
]);
});

it("Can record notebooks being opened", () => {
const name = "some notebook";
const path = "some path";
const notebook = { name, path };

mostRecentActivity.notebookWasItemOpened(accountId, notebook);

const activity = mostRecentActivity.getItems(accountId);
expect(activity).toEqual([expect.objectContaining(notebook)]);
});

it("Filters out duplicates", () => {
const name = "some notebook";
const path = "some path";
const notebook = { name, path };
const sameNotebook = { name, path };

mostRecentActivity.notebookWasItemOpened(accountId, notebook);
mostRecentActivity.notebookWasItemOpened(accountId, sameNotebook);

const activity = mostRecentActivity.getItems(accountId);
expect(activity.length).toEqual(1);
expect(activity).toEqual([expect.objectContaining(notebook)]);
});

it("Allows for multiple accounts", () => {
const name = "some notebook";
const path = "some path";
const notebook = { name, path };

const anotherNotebook = { name: "Another " + name, path };
const anotherAccountId = "Another " + accountId;

mostRecentActivity.notebookWasItemOpened(accountId, notebook);
mostRecentActivity.notebookWasItemOpened(anotherAccountId, anotherNotebook);

expect(mostRecentActivity.getItems(accountId)).toEqual([expect.objectContaining(notebook)]);
expect(mostRecentActivity.getItems(anotherAccountId)).toEqual([expect.objectContaining(anotherNotebook)]);
});

it("Can store multiple distinct elements, in FIFO order", () => {
const name = "some notebook";
const path = "some path";
const first = { name, path };
const second = { name: "Another " + name, path };
const third = { name, path: "Another " + path };
it("Does not store duplicate entries", () => {
const collectionId = "some collection";
const databaseId = "some database";
const collection = {
id: observable(collectionId),
databaseId,
};

mostRecentActivity.notebookWasItemOpened(accountId, first);
mostRecentActivity.notebookWasItemOpened(accountId, second);
mostRecentActivity.notebookWasItemOpened(accountId, third);
collectionWasOpened(accountName, collection);
collectionWasOpened(accountName, collection);

const activity = mostRecentActivity.getItems(accountId);
expect(activity).toEqual([third, second, first].map(expect.objectContaining));
const activity = getItems(accountName);
expect(activity).toEqual([
expect.objectContaining({
type: Type.OpenCollection,
collectionId,
databaseId,
}),
]);
});
});
Loading
Loading