fix partitionkey value fetching #1972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchske
previously approved these changes
Sep 19, 2024
languy
previously approved these changes
Sep 19, 2024
sunghyunkang1111
dismissed stale reviews from languy and vchske
via
2e01e0a
jawelton74
approved these changes
Sep 19, 2024
vchske
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview this branch
Currently, we are not adding the partition key value for any nested partition key when doing operations on SDK as a workaround to deal with errors with documents with nested partitionkey.
However, if it has hierarchical partition keys with a nested partition key, sending only the partition key value for the non nested partition key will cause an error.
So, the best way is to actually pass the partition key value when necessary
In addition, when the document is newly created from the Data Explorer, when you try to edit the newly created document without navigating away, causes error because we are resetting the clicked row index. So fixed this issue as well.