[tcgc] make artifical content type parameter optional #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iscai-msft
requested review from
lmazuel,
m-nash,
srnagar,
joheredi,
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
|
All changed packages have been documented. |
| @@ -175,13 +175,15 @@ function createContentTypeOrAcceptHeader( | |||
| }; | |||
| } | |||
| // No need for clientDefaultValue because it's a constant, it only has one value | |||
| // Since these are the created accept and content type header parameters, we don't make them required. | |||
There was a problem hiding this comment.
What's the motivation for this change? Since these are synthesized, constant, params, they won't show up in public surface area so there's no way for callers to set them. Maybe I'm missing something.
|
You can try these changes at https://cadlplayground.z22.web.core.windows.net/typespec-azure/prs/425/ Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/typespec-azure/prs/425/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it wasn't defined in the tsp, we can't assume that it's required on the service. Should default to optional. If it's required, it should be explicitly defined in the tsp