profile: prevent accidental "undefined" as profile identifier #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abarisain
force-pushed
the
feature/prevent_undefined_profile
branch
from
1b64b6d
to
4e42f1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Si on utilise pas typescript, il est relativement facile de mettre l'identifier
"undefined"sur un profil en passant une variable mal initialisée.Le contrat API etant d'explicitement passer null pour enlever l'identifier, je pense qu'il faut qu'on refuse plutot que convertir en null.
Autant on peut se dire que
identify()pourrait etre interprété en logout, autant si on faitidentify(myID)mais quemyIDn'est accidentellement pas defined, c'est plus dur a débuggerDeux autres pistes:
[object Object]) pour être sur qu'on oublie pas ça dans d'autres plugins