WIP Replace kotest-property with parameterize

BenWoodworth · May 18, 2024 · 41b70f2 · 41b70f2
1 parent b549697
commit 41b70f2
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/src/commonTest/kotlin/test/parameterizeTest.kt b/src/commonTest/kotlin/test/parameterizeTest.kt
@@ -3,14 +3,13 @@ package net.benwoodworth.knbt.test
 import com.benwoodworth.parameterize.ExperimentalParameterizeApi
 import com.benwoodworth.parameterize.ParameterizeScope
 import com.benwoodworth.parameterize.parameterize
-import kotlin.test.DefaultAsserter.fail
 
 inline fun parameterizeTest(
     recordFailures: Long = 10,
     maxFailures: Long = Long.MAX_VALUE,
     block: ParameterizeScope.() -> Unit
 ) {
-    var emptyTest = true
+    var hasTestCases = false
 
     parameterize(
         onFailure = {
@@ -19,12 +18,12 @@ inline fun parameterizeTest(
         }
     ) {
         block()
-        emptyTest = false
+        hasTestCases = true
     }
 
-    if (emptyTest) {
-        fail("Bad parameterized test: All test cases skipped")
-    }
+    // There were no failures if it made it to this point, but check
+    // just in case all test cases were skipped to empty parameters.
+    check(hasTestCases) { "Bad parameterized test: All test cases skipped" }
 }
 
 @OptIn(ExperimentalParameterizeApi::class)