keep extract and rename logic if using return_datasets #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YoelShoshan
reviewed
Feb 9, 2025
| columns_to_extract=pairs_columns_to_extract, | ||
| rename_columns=pairs_rename_columns, | ||
| columns_to_extract=None, | ||
| rename_columns=None, |
There was a problem hiding this comment.
not sure about the columns_to_extract part,
it's possibly better to still keep using it in the op to make sure it's not too "heavy" per sample.
@mosheraboh do you think it matters or not ?
I think that you wanted mainly the rename to happen (also) in the dataframe.
Any option that you and @alex-golts agree on is fine by me.
There was a problem hiding this comment.
Was it (pairs_columns_to_extract ) set to None before? If not, I suggest keeping it.
YoelShoshan
approved these changes
Feb 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.