This repository has been archived by the owner on Jan 25, 2020. It is now read-only.
Upgrade to webpack 4 and use react-scripts over custom configs #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #167 +/- ##
==========================================
- Coverage 23.57% 21.71% -1.87%
==========================================
Files 82 82
Lines 933 967 +34
Branches 110 98 -12
==========================================
- Hits 220 210 -10
- Misses 628 682 +54
+ Partials 85 75 -10
Continue to review full report at Codecov.
|
kedarv
requested review from
colejoh,
pkfoury and
nickysemenza
and removed request for
colejoh
|
This PR also adds some style regressions to non a11y links (eg. logout button on nav, signup button). I figured these pages will be redone after the event ends anyway, so there's no point in going back and fixing those. |
pkfoury
approved these changes
Oct 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this should not be merged until after BM 6 finishes up completely (only non-critical traffic - no sponsors/hackers/etc. visiting)
This PR removes custom build configs/scripts in favor of
react-scripts, which also brings in support for Webpack 4 (currently using Webpack 2) which features super fast builds (20-25s vs 45-50s on my Macbook) and smaller bundles (376KB vs ~400KB). Best of all, it reduces the codebase and helps keep this repo more maintainable.