Table settings updates #15527
Merged
Table settings updates #15527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mponent bindings, restrict format setting to own context only
…ity with table format and condition settings
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
deanhannigan
approved these changes
Feb 14, 2025
There was a problem hiding this comment.
LGTM! Ran into one small issue when running through the condition behaviour. Other than that, the binding restrictions are in place and the features are working great 🚀
BUG - Preview will crash if a newly added condition is saved on a GridBlock without setting an initial value.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR restores the table "Format" setting, which had been reverted due to it breaking the existing table "Conditions" setting. This PR allows both conditions and formatting to work as intended.
There is an intended difference to the context (bindings) available to each setting.
This difference is intended and is mainly due to performance constraints.
This fix was not possible without adding (another) new concept to the manifest -
contextAccess, which acts as an escape hatch for this and any future binding problems caused by how we render certain settings using a pseudo component definition. This has been added to the appropriate type, and should not normally ever need used.Other stuff
Fixed some inconsistencies between which bindings are available in real settings versus the same setting when configuring conditional UI.