Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test URL variables in design #15534

Merged
merged 15 commits into from
Feb 13, 2025
Merged

Test URL variables in design #15534

merged 15 commits into from
Feb 13, 2025

Conversation

PClmnt
Copy link
Collaborator

@PClmnt PClmnt commented Feb 12, 2025

Description

This PR adds the ability for users to test their URL variables. When building screens with dynamic URL parameters (like /employees/:id), this lets the user provide an example value so they can see how it affects the screen

Also, to make it easier to understand what is needed, the placeholder is based on the route of the screen, so say for /employees/:test/validate/:id, the placeholder field shows an example like "1/validate/2".

Screenshots

Screen.Recording.2025-02-11.at.13.34.38.mov

Launchcontrol

  • Adds a input within the screen settings that enables the testing of URL variables within the design section.

Feature branch env

Feature Branch Link

Copy link

qa-wolf bot commented Feb 12, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@github-actions github-actions bot added firestorm Data/Infra/Revenue Team size/m labels Feb 12, 2025
@PClmnt PClmnt changed the title Feat/url binding default Test URL variables in design Feb 12, 2025
@PClmnt PClmnt requested a review from aptkingston February 12, 2025 13:46
@PClmnt PClmnt added the feature-branch Release this PR code into a feature branch label Feb 12, 2025
Copy link
Member

@aptkingston aptkingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Pete. I played around with this locally and couldn't find any issues with it functionally. It handled everything I threw at it, so nice job 👌

Just a few style points:

  • We shouldn't show this at all if your screen doesn't use any URL params. Right now it always shows, but serves no purpose if you aren't using any params
  • Is it worth updating the copy slightly to make it clear it's temporary? With the new state panel we are very explicit with "Set temporary value for design preview". This is basically an identical feature for URL params. I'm not totally set on this though - I don't really mind either way.
  • Style wise it's a bit unique, but that's probably fine. It might be nice to at least align it with our other settings though, which would mean making hardcoded prefix section 98px wide rather than 40%. Could we maybe update the label to be the same colour as the rest of the settings labels too? And probably also update the casing to remove the capital letters other than the first one.

@github-actions github-actions bot added size/l and removed size/m labels Feb 13, 2025
Copy link
Member

@aptkingston aptkingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@PClmnt PClmnt enabled auto-merge February 13, 2025 17:24
@PClmnt PClmnt merged commit 5b63804 into master Feb 13, 2025
20 checks passed
@PClmnt PClmnt deleted the feat/url-binding-default branch February 13, 2025 17:34
@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-branch Release this PR code into a feature branch firestorm Data/Infra/Revenue Team size/l
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants