Ops/aas with minio gateway #15587
Merged
Ops/aas with minio gateway #15587
+95
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
samwho
reviewed
Feb 20, 2025
adrinr
reviewed
Feb 20, 2025
We did, yes. Here's the run -> https://github.com/Budibase/budibase-deploys/actions/runs/13437085341 and here's the branch that hardcodes The feature branch behaves the same way as the regular ones. |
adrinr
approved these changes
Feb 21, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Configures minio to run under gateway mode to allow persistent storage when Budibase is running in Azure App Service. Requires
AZURE_STORAGE_ACCOUNTandAZURE_STORAGE_KEYto be set when executing the container.