Delete entire pods in lifecycle environment #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klingerf
reviewed
May 24, 2018
There was a problem hiding this comment.
Cool, this fixes the CrashLoopBackoff. 🎉
FWIW, I tested this on kubernetes 1.10, and the redeployer pod failed with:
Error from server (Forbidden): pods is forbidden: User "system:serviceaccount:lifecycle:default" cannot list pods in the namespace "lifecycle"
Once I created a clusterrolebinding for the lifecycle namespace, it succeeded:
kubectl create clusterrolebinding lifecycle-cluster-admin --clusterrole=cluster-admin --serviceaccount=lifecycle:default
Maybe we should add that clusterrolebinding as a separate object in the k8s config?
lifecycle/lifecycle.yml
Outdated
| - name: redeploy | ||
| configMap: | ||
| name: redeploy | ||
| defaultMode: 0744 |
9 tasks
The lifecycle environment was testing service discovery via bb-terminus container exit. This did not play well with k8s's `CrashLoopBackoff`. Disable bb-terminus container exit in favor of a `redeployer` script, that deletes each bb-terminus pod once per minute. Also create `ServiceAccount`, `ClusterRole`, and `ClusterRoleBinding`, and install conduit into conduit-lifecycle namespace. Fixes #42, relates to #43. Signed-off-by: Andrew Seigner <[email protected]>
klingerf
approved these changes
May 24, 2018
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lifecycle environment was testing service discovery via bb-terminus
container exit. This did not play well with k8s's
CrashLoopBackoff.Disable bb-terminus container exit in favor of a
redeployerscript,that deletes each bb-terminus pod once per minute.
Fixes #42, relates to #43.
Signed-off-by: Andrew Seigner [email protected]