-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add c bindings + Updated camke builds #166
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…+ add workflow for the c libs
cmmarslender
changed the title
Add c bindings for create_discriminant, prove, and verify_n_wesolowski
Add c bindings + Updated camke builds
Mar 7, 2024
hoffmang9
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial goal here was to make c wrappers for
create_discriminant
,prove
andverify_n_wesolowski
that mirrors the python bindings, but returns c types. This then enables me to call these from go bindings (which don't support c++ types, only c). I created those wrappers, then needed to (optionally) build the shared and static libraries for all our supported platforms, via cmake.Well, this then required the cmake file to support windows. Once we had the windows support in cmake, it made sense to apply the same patterns from other repos (such as chiapos) to simplify the setup.py to use cmake for windows as well, instead of the split logic for windows/not-windows that previously existed.
So this PR does two things:
Testing
pip uninstall chiavdf
, and installed the version from this branch. Node was able to sync new blocks.For now, the c libraries just exist as artifacts on the new workflow. May update this later to package into something a bit easier to consume downstream, but that can be in a follow on PR