Fix family-register page on mobile and desktop #6876
Conversation
romdricks
requested review from
DawoudIO,
MrClever and
DAcodedBEAT
as code owners
|
@romdricks can you provide screenshots? |
| @@ -26,7 +26,7 @@ | |||
| position: relative; | |||
| } | |||
| </style> | |||
| <div class="register-box" style="width: 75%;"> | |||
| <div class="register-box" style="min-height: 100vh; width: 75%;"> | |||
There was a problem hiding this comment.
I vaguely remember 100vh being problematic on mobile, does it work in this case? How was this tested, if you don't mind me asking?
There was a problem hiding this comment.
Yes it does work. I tested it on a staging site for these OS and browsers:
Desktop: Windows OS (Firefox, Chrome, Edge)
Mobile: Android OS & Apple OS (Chrome, Brave)
There was a problem hiding this comment.
As per discussion in the dev chat space (and on #6830), this appears to be a strange problem only affecting the self-registration pages which in turn use a completely different mix of CSS compared to the rest of the site. We can kludge a fix into the container as this PR proposes, but there's no guarantee we won't see this behaviour elsewhere (as we don't know the root cause). There seems to be some weird implied container dimensions creeping in from the combination of bootstrap, font awesome and our own CSS. I'm not a huge fan of band-aid solutions to fix a behaviour when the root cause is unknown.
My $0.02 worth.
There was a problem hiding this comment.
Okay. I do understand. Your guidance in going forward is appreciated.
|
@romdricks / @MrClever since this PR is stalled, should we close this out? |
|
Closing this PR as we investigate root cause CSS weirdness. We can re-open this if we run out of options 👍🏻 |
Description & Issue number it closes
Fix Form not showing properly on mobile and desktop. #6830
Fix Footer overlapping buttons (previous, next & register)
Type of change