Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cc-orga-member-*: migrate to the new state API #1164

Open
florian-sanders-cc opened this issue Oct 2, 2024 · 0 comments · May be fixed by #1306
Open

cc-orga-member-*: migrate to the new state API #1164

florian-sanders-cc opened this issue Oct 2, 2024 · 0 comments · May be fixed by #1306
Assignees
@florian-sanders-cc
Labels
breaking-change Something that will required a major semver release
Milestone
State migration

Comments

@florian-sanders-cc
Copy link
Contributor

Context

We've recently migrated a lot components the our new state API but the cc-orga-member-list still relies on the old one.
The component was in modification (Element Internals) when we worked on the migration for others so it was not processed with the others.

Now that the component supports ElementInternals and is typechecked, we can migrate it.
@florian-sanders-cc florian-sanders-cc added the breaking-change Something that will required a major semver release label Oct 2, 2024
@florian-sanders-cc florian-sanders-cc added this to the State migration milestone Oct 2, 2024
@florian-sanders-cc florian-sanders-cc self-assigned this Oct 2, 2024
florian-sanders-cc added a commit that referenced this issue Jan 17, 2025
@florian-sanders-cc
refactor(cc-orga-member-list)!: rework properties to avoid impossible…
898812e 
… states

BREAKING CHANGE: the properties have changed
- `members` property has been renamed to `memberListState`,
- `members.state` property has been renamed to `memberListState.type`,
- `members.value` property has been renamed to
  `memberListState.memberList`,
- same logic applies to `memberList` items where:
  - `member` has been renamed to `state`,
  - `member.state` has been renamed to `state.type`.

Fixes #1164
@florian-sanders-cc florian-sanders-cc linked a pull request Jan 17, 2025 that will close this issue
Open
florian-sanders-cc added a commit that referenced this issue Jan 24, 2025
@florian-sanders-cc
refactor(cc-orga-member-list)!: rework properties to avoid impossible…
3bfd2db 
… states

BREAKING CHANGE: the properties have changed
- `members` property has been renamed to `memberListState`,
- `members.state` property has been renamed to `memberListState.type`,
- `members.value` property has been renamed to
  `memberListState.memberList`,
- same logic applies to `memberList` items where:
  - `member` has been renamed to `state`,
  - `member.state` has been renamed to `state.type`.

Fixes #1164
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@florian-sanders-cc florian-sanders-cc

Labels
breaking-change Something that will required a major semver release
Projects
None yet
Milestone
State migration
Development

Successfully merging a pull request may close this issue.

refactor(cc-orga-member-list)!: rework properties to avoid impossible CleverCloud/clever-components
1 participant
@florian-sanders-cc