refactor(cc-orga-member-list)!: rework properties to avoid impossible #1306
+713
−527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florian-sanders-cc
added
the
breaking-change
florian-sanders-cc
requested review from
hsablonniere,
Galimede,
roberttran-cc,
pdesoyres-cc and
HeleneAmouzou
|
🔎 A preview has been automatically published : https://clever-components-preview.cellar-c2.services.clever-cloud.com/cc-orga-member/migrate-to-new-state/index.html. This preview will be deleted once this PR is closed. |
roberttran-cc
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
Perfect!
I don't know if it is the right place but maybe we could take the opportunity to factorize the Authorisations interface that is duplicated between src/components/cc-orga-member-card/cc-orga-member-card.types.d.ts and src/components/cc-orga-member-list/cc-orga-member-list.types.d.ts.
interface Authorisations {
invite: boolean;
edit: boolean;
delete: boolean;
}
pdesoyres-cc
approved these changes
Jan 22, 2025
… states BREAKING CHANGE: the properties have changed - `member` property has been renamed to `state`, - `member.state` property has been renamed to `state.type`.
… states BREAKING CHANGE: the properties have changed - `members` property has been renamed to `memberListState`, - `members.state` property has been renamed to `memberListState.type`, - `members.value` property has been renamed to `memberListState.memberList`, - same logic applies to `memberList` items where: - `member` has been renamed to `state`, - `member.state` has been renamed to `state.type`. Fixes #1164
florian-sanders-cc
force-pushed
the
cc-orga-member/migrate-to-new-state
branch
from
898812e to
3bfd2db
Compare
florian-sanders-cc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1164
What does this PR do?
cc-orga-member-listcomponent to the new state API.How to review?
demo-smartto see if all features still work properly,