Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: model download fails when server defaults to gzip #242

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ansonkao
Copy link

gzip breaks Content-Length and makes downloads slower.
Content-Length is expected by the progress-bar logger in download_file()

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Feb 25, 2025
@ansonkao
Copy link
Author

Confirming this resolved an issue I had with a CDN I was downloading files from

@ansonkao ansonkao changed the title Prevent gzip when downloading models @ models.py Fix: model download fails when server defaults to gzip Feb 25, 2025
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
comfy_cli/command/models/models.py 0.00% 1 Missing ⚠️
Flag Coverage Δ
unittests 44.75% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
comfy_cli/command/models/models.py 32.98% <0.00%> (-0.18%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant