Use upstream Manager.

[robinjhuang]

• Includes bug fixes from manager:
  ltdrdata/ComfyUI-Manager@488f023
• Fixed: migrating custom nodes: uses restore-to to fix importing custom nodes.
• Remove extra ComfyUI-Manager when migrating/importing from another ComfyUI install
• Updated requirements.compiled

┆Issue is synchronized with this Notion page by Unito

[socket-security]

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

[robinjhuang]

Rebased and tested again. @webfiltered tests are failing because I updated the version to 0.4.22 and the screenshots don't match on the error page anymore. How do I update that?

[webfiltered]

Process is currently:

1. Run tests
2. Verify that the only things changed are what's expected
3. Run this locally:

yarn run test:e2e:update

5. Commit new expectations

All screenshot diffs are overwritten by playwright at once - doing a partial diff requires discarding any updated expectations before committing.

Edit: Adding this to testing README. Done.

[webfiltered]

Or.. we could just resolve the problem at the source.

• [e2e] Ignore desktop version in screenshot validation #1004

[robinjhuang]

@webfiltered Closed this by accident. I rebased and tested. It should fix a few issues with current manager, including migrating custom nodes. Can you PTAL when you have time?

[webfiltered]

Suggested change

	// Match the original case: 2 packages (uv + toml) | Added in https://github.com/ltdrdata/ComfyUI-Manager/commit/816a53a7b1a057af373c458ebf80aaae565b996b
	const twoPackages = /\bWould install 2 packages(\s+\+ (toml|uv)==[\d.]+){2}\s*$/;
	// Match the new case: 1 package (chardet) | Added in https://github.com/ltdrdata/ComfyUI-Manager/commit/60a5e4f2614c688b41a1ebaf0694953eb26db38a
	const onePackage = /\bWould install 1 package\s+\+ chardet==[\d.]+\s*$/;
	return twoPackages.test(output) || onePackage.test(output);
	// Match the new case: 1 package (chardet) | Added in https://github.com/ltdrdata/ComfyUI-Manager/commit/60a5e4f2614c688b41a1ebaf0694953eb26db38a
	const latest = /\bWould install 1 package\s+\+ chardet==[\d.]+\s*$/;
	// Match upgrade from <0.4.18: 2 additional packages (uv + toml) | Added in https://github.com/ltdrdata/ComfyUI-Manager/commit/816a53a7b1a057af373c458ebf80aaae565b996b
	const allPackages = /\bWould install 3 packages(\s+\+ (toml|uv|chardet)==[\d.]+){2}\s*$/;
	return latest.test(output) || allPackages.test(output);

If you're updating from <0.4.18 to this commit, you should need all three.. however.. possibly a better idea in a second..

[webfiltered]

Suggested change

	// Match the original case: 2 packages (uv + toml) | Added in https://github.com/ltdrdata/ComfyUI-Manager/commit/816a53a7b1a057af373c458ebf80aaae565b996b
	const twoPackages = /\bWould install 2 packages(\s+\+ (toml|uv)==[\d.]+){2}\s*$/;
	// Match the new case: 1 package (chardet) | Added in https://github.com/ltdrdata/ComfyUI-Manager/commit/60a5e4f2614c688b41a1ebaf0694953eb26db38a
	const onePackage = /\bWould install 1 package\s+\+ chardet==[\d.]+\s*$/;
	return twoPackages.test(output) || onePackage.test(output);
	// Match the original case: 2 packages (uv + toml) | Added in https://github.com/ltdrdata/ComfyUI-Manager/commit/816a53a7b1a057af373c458ebf80aaae565b996b
	// Match the new case: 1 package (chardet) | Added in https://github.com/ltdrdata/ComfyUI-Manager/commit/60a5e4f2614c688b41a1ebaf0694953eb26db38a
	const anyCombination = /\bWould install [1-3] packages(\s+\+ (toml|uv|chardet)==[\d.]+){1,3}\s*$/;
	return anyCombination.test(output);

If they downloaded a custom node that added just one of the required packages, we should still just auto-update, right?

[webfiltered]

Would really like to limit our use of node:fs to CI scripts and dev stuff. Unless node / Electron is silently wrapping this in some real multi-threaded framework magic, this can block the entire main process from responding.

node:fs/promises is the way (we have our own wrappers for fs.access)