Set cookie same site protection to nil #1608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an attempt to fix an issue we're seeing where signing in with Omniauth isn't working in Safari. Setting this value to `nil` (which means the `SameSite` attribute is left unset) should in theory be the same as setting to to `lax` (which means the `SameSet` attribute is set to `Lax`), however it seems like Safari treats these differently: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie#lax omniauth/omniauth-oauth2#155 (comment)
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
richardpattinson
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix an issue we're seeing where signing in with Omniauth isn't working in Safari. Setting this value to
nil(which means theSameSiteattribute is left unset) should in theory be the same as setting to tolax(which means theSameSetattribute is set toLax), however it seems like Safari treats these differently:https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie#lax
omniauth/omniauth-oauth2#155 (comment)
Trello Card