Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7748] remove pii from logs sent to logitio #4797

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

kennyevil
Copy link
Contributor

@kennyevil kennyevil commented Nov 7, 2024

Context

Rails Semantic Logger does not filter sensitive information, as defined by the Rails.configuration.filter_paramters setting from the sql statements in the log file.

Changes proposed in this pull request

I have forked the repo and put in a Pull Request to address this issue.

I've also added audited_changes as a filtered parameter to ensure PII does not sent to third parties that way.

Use the forked version of Rails Semantic Logger until the PR has been accepted.

Screenshot 2024-11-07 at 12 39 29 Screenshot 2024-11-07 at 12 39 01

Guidance to review

Important business

  • Does this PR introduce any PII fields that need to be overwritten or deleted in db/scripts/sanitise.sql?
  • Does this PR change the database schema? If so, have you updated the config/analytics.yml file and considered whether you need to send 'import_entity' events?
  • Do we need to send any updates to DQT as part of the work in this PR?
  • Does this PR need an ADR?

NB: Please notify the #twd_data_insights team and ask for a review if new fields are being added to analytics.yml

Copy link

sonarcloud bot commented Nov 7, 2024

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.67%. Comparing base (3e8334f) to head (2ec8ef2).
Report is 84 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4797      +/-   ##
==========================================
- Coverage   94.67%   94.67%   -0.01%     
==========================================
  Files         735      735              
  Lines       15954    15950       -4     
==========================================
- Hits        15105    15101       -4     
  Misses        849      849              
Flag Coverage Δ
unittests 94.67% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tomtrentham tomtrentham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go ahead with this and keep checking in with the Gem PR to get back to the main version when we can.

@kennyevil kennyevil merged commit 8969194 into main Nov 13, 2024
35 checks passed
@kennyevil kennyevil deleted the feature/7748-remove-pii-from-logs-sent-to-logitio branch November 13, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants