[7797] Allow a CSV bulk upload to be cancelled through the Summary page #4800
+1,560
−178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Outline of error handling and rollback
We can now import into the DB
Add `validated` and `submitted` states because we need interim states between two new states between `pending` and `completed` to - indicate that the upload has been validated (and has no errors) - indicate that the upload has been submitted but has not finished processing.
This spec now invokes the dry run and submit background jobs to complete the import of valid records.
Co-authored-by: Serafeim Maroulis <[email protected]>
Leaving the rendering of error messages for later tickets.
This means that the creation of row records happens inside a job (and not as part of the same database transation that creates the upload record.
Co-authored-by: De Fong <[email protected]>
Co-authored-by: De Fong <[email protected]>
Co-authored-by: De Fong <[email protected]>
* Render info about the trainee uploads
Reyko
changed the title
Reyko
force-pushed
the
7797-allow-a-csv-bulk-upload-to-be-cancelled-through-the-summary-page
branch
from
1fbe098
to
134951a
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 7744-create-upload-summary-page-part-2 #4800 +/- ##
=======================================================================
Coverage 96.02% 96.02%
=======================================================================
Files 722 722
Lines 15735 15738 +3
=======================================================================
+ Hits 15109 15112 +3
Misses 626 626
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Reyko
force-pushed
the
7744-create-upload-summary-page-part-2
branch
2 times, most recently
from
49e4470
to
48ebc09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
7797-allow-a-csv-bulk-upload-to-be-cancelled-through-the-summary-page
Changes proposed in this pull request
cancelledGuidance to review
Important business
NB: Please notify the #twd_data_insights team and ask for a review if new fields are being added to analytics.yml