Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7813] Fix example_data.rake #4809

Merged
merged 2 commits into from
Nov 13, 2024
Merged

[7813] Fix example_data.rake #4809

merged 2 commits into from
Nov 13, 2024

Conversation

Reyko
Copy link
Contributor

@Reyko Reyko commented Nov 12, 2024 •
edited
Loading

Context

7813-fix-example-data-rake

Changes proposed in this pull request

  • Fix provider creation in the task
  • Fix feature spec

Guidance to review

Important business

  • Does this PR introduce any PII fields that need to be overwritten or deleted in db/scripts/sanitise.sql?
  • Does this PR change the database schema? If so, have you updated the config/analytics.yml file and considered whether you need to send 'import_entity' events?
  • Do we need to send any updates to DQT as part of the work in this PR?
  • Does this PR need an ADR?

NB: Please notify the #twd_data_insights team and ask for a review if new fields are being added to analytics.yml

@Reyko Reyko changed the title Fix example_data.rake [7813] Fix example_data.rake Nov 12, 2024
@Reyko Reyko added bug Something isn't working deploy labels Nov 12, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Reyko Reyko marked this pull request as ready for review November 12, 2024 16:58
@Reyko Reyko merged commit f25b72e into main Nov 13, 2024
32 of 33 checks passed
@Reyko Reyko deleted the 7813-fix-example-data-rake branch November 13, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennyevil kennyevil kennyevil approved these changes

Assignees
No one assigned
Labels
bug Something isn't working deploy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Reyko @kennyevil