Fix the unrevealed walls being hidden by default #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myk002
reviewed
Jan 27, 2025
| @@ -18,8 +18,8 @@ struct GameConfiguration { | |||
| bool show_announcements = false; | |||
| bool show_keybinds = false; | |||
| bool single_layer_view; | |||
| bool shade_hidden_tiles = false; | |||
| bool show_hidden_tiles; | |||
| bool shade_hidden_tiles = true; | |||
There was a problem hiding this comment.
after seeing the difference, I'd actually vote for shade_hidden_tiles being kept as false by default..
There was a problem hiding this comment.
ok like i get that, but the issue is that reveals everything in megashots (the FUN). im down to work on a dififerent version that explodes the layers like you also wanted but for now, based on streamer feedback and my own opinion, i'd like it to be back on.
myk002
reviewed
Jan 28, 2025
myk002
approved these changes
Jan 30, 2025
|
Could I possibly get membership in your org? That way I might be able to resolve conflicts before merging and do other usual PR maintenance tasks. |
|
Certainly! I will ping u in discord when i get that done later (currently out and about) |
myk002
approved these changes
Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIxes: #168