Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Cursor tracking mode as an option. #173

Merged
merged 8 commits into from
Feb 10, 2025

Conversation

realSquidCoder
Copy link
Collaborator

Fixes #170

@realSquidCoder realSquidCoder marked this pull request as ready for review January 25, 2025 20:57
Copy link
Member

@myk002 myk002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about the config parsing code in Config.cpp? I see TRACK_MODE:FOCUS being interpreted there

Copy link
Member

@myk002 myk002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you now remove the unused values from the enum?

@realSquidCoder
Copy link
Collaborator Author

can you now remove the unused values from the enum?

There is still code that references the enum values. I simply removed the ability to set the value as a stop gap bc we may find a better way to do things later on

@myk002
Copy link
Member

myk002 commented Feb 9, 2025

there's git history if we need it back. dead code is a liability. I'd say remove the unused enum values and the related code.

@realSquidCoder
Copy link
Collaborator Author

Ok I'll tackle that after work and get it cleaned up for review

@realSquidCoder
Copy link
Collaborator Author

done and should be ready

@myk002 myk002 merged commit 9f5aa0f into DFHack:master Feb 10, 2025
4 checks passed
@realSquidCoder realSquidCoder deleted the squid-remove-cursor-track branch February 10, 2025 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

ambiguous follow modes
2 participants