-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the Cursor tracking mode as an option. #173
Remove the Cursor tracking mode as an option. #173
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about the config parsing code in Config.cpp? I see TRACK_MODE:FOCUS being interpreted there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you now remove the unused values from the enum?
There is still code that references the enum values. I simply removed the ability to set the value as a stop gap bc we may find a better way to do things later on |
there's git history if we need it back. dead code is a liability. I'd say remove the unused enum values and the related code. |
Ok I'll tackle that after work and get it cleaned up for review |
done and should be ready |
Fixes #170