Skip to content
This repository has been archived by the owner on Feb 18, 2022. It is now read-only.

Issue 21 - migrate command not working #26

Merged
merged 3 commits into from
Dec 29, 2021

Conversation

eafarooqi
Copy link
Contributor

  • ->rtrim('.php') should be changed to ->replace('.php', '') as rtrim destroy the class name if p or h is the last character of class name.
  • Double slash \\ included in the path, should be replaced with single slash \

Fix to this issue: #21

@DarkGhostHunter Please accept and merge, as the plugin is unusable without this fix

@eafarooqi eafarooqi changed the title Issue 21 Issue 21 - migrate command not working Nov 18, 2021
@coveralls
Copy link

coveralls commented Nov 18, 2021

Pull Request Test Coverage Report for Build 1634000679

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.869%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Migrator/Pipes/FindModelsWithSettings.php 0 3 0.0%
Totals Coverage Status
Change from base Build 1573764972: 0.0%
Covered Lines: 547
Relevant Lines: 589

💛 - Coveralls

@SalemCode8
Copy link

@DarkGhostHunter We need this fix to be able to use the package

@rudolfbruder
Copy link

@DarkGhostHunter Yeah please approve this pull request

@rudolfbruder
Copy link

rudolfbruder commented Dec 28, 2021

@eafarooqi I tried your fix however what I am ending up with is this:
image
Do you think it's connected to your fix. The settable type does not have \ between the words and therefore it does not work.

However when I run $user-settings()->initialize(); it duplicates the rows of settings for that user and creates rows with proper backslashes like this:
image

Check the issue here

@DarkGhostHunter
Copy link
Owner

DarkGhostHunter commented Dec 29, 2021 via email

@DarkGhostHunter DarkGhostHunter merged commit c6ed8e5 into DarkGhostHunter:master Dec 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants