Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-8627: Collect App Hitches in the SDK #2214

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

simaoseica-dd
Copy link
Contributor

What and why?

This PR creates the engine to collect View Hitches (Slow frames) that occur during the lifecycle of a View.
The proposed solution is defined in the internal RFC.

How?

To scale the entities that observe the render loop, it was created the DisplayLinker.
Any reader (RenderLoopReader) that wants to be notified about frame rendering can register to the DisplayLinker:
displayLinker.register(vitalRefreshRateReader)

This PR lists two RenderLoopReader:

  • VitalRefreshRateReader - A class that reads the refresh rate (frames per second)
  • ViewHitchesReader - A class that reads View Hitches or Slow frames.

For a better understanding of the relationships, the figure below depicts the idea:
RenderLoopObserver

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes
  • Add Objective-C interface for public APIs (see our guidelines [internal]) and run make api-surface)

@simaoseica-dd simaoseica-dd requested review from a team as code owners March 3, 2025 13:12
@simaoseica-dd simaoseica-dd force-pushed the simaoseica/RUM-8627/collect-app-hitches-in-the-sdk branch from d72c3c6 to a792bfb Compare March 3, 2025 14:09
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Mar 3, 2025

Datadog Report

Branch report: simaoseica/RUM-8627/collect-app-hitches-in-the-sdk
Commit report: 4972032
Test service: dd-sdk-ios

✅ 0 Failed, 1304 Passed, 2522 Skipped, 1m 26.09s Total duration (1m 12.71s time saved)

@simaoseica-dd simaoseica-dd force-pushed the simaoseica/RUM-8627/collect-app-hitches-in-the-sdk branch from a792bfb to 69dbacc Compare March 3, 2025 14:37
@simaoseica-dd simaoseica-dd force-pushed the simaoseica/RUM-8627/collect-app-hitches-in-the-sdk branch from 69dbacc to 4972032 Compare March 3, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant