Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test optimization][SDTEST-1355] Fix ATR + DI #5176

Merged
merged 9 commits into from
Feb 3, 2025

Conversation

juan-fernandez
Copy link
Collaborator

@juan-fernandez juan-fernandez commented Jan 30, 2025

What does this PR do?

  • Add extra useful logs for debugging
  • Don't crash the worker thread of the breakpoint already exists
  • Store active probes in a Map
  • Add function to remove all DI probes
  • Do not remove DI probes on test finish in jest, as retries are deferred to the end of the test file execution, not executed immediately after the first attempt fails: this makes the assumption that tests run sequentially wrong.
  • Remove DI probes on jest's test suite finish (test file)

Motivation

Try to understand why DI info is sometimes missing.

Plugin Checklist

Since this is a refactor, just the already present tests should be enough.

Copy link

github-actions bot commented Jan 30, 2025

Overall package size

Self size: 8.56 MB
Deduped: 94.95 MB
No deduping: 95.47 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.6.1 | 2.59 MB | 2.73 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 81.08%. Comparing base (69426fb) to head (2955b0b).
Report is 17 commits behind head on master.

Files with missing lines Patch % Lines
packages/datadog-plugin-cucumber/src/index.js 0.00% 6 Missing ⚠️
packages/datadog-plugin-mocha/src/index.js 0.00% 5 Missing ⚠️
...src/ci-visibility/dynamic-instrumentation/index.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5176      +/-   ##
==========================================
+ Coverage   81.07%   81.08%   +0.01%     
==========================================
  Files         479      479              
  Lines       21338    21355      +17     
==========================================
+ Hits        17299    17315      +16     
- Misses       4039     4040       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Jan 30, 2025

Benchmarks

Benchmark execution time: 2025-01-31 14:56:21

Comparing candidate commit 2955b0b in PR branch juan-fernandez/add-extra-logs-to-di with baseline commit 69426fb in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 905 metrics, 27 unstable metrics.

scenario:plugin-graphql-with-depth-and-collapse-on-18

  • 🟩 max_rss_usage [-68.196MB; -56.588MB] or [-6.992%; -5.802%]

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jan 30, 2025

Datadog Report

Branch report: juan-fernandez/add-extra-logs-to-di
Commit report: 411b730
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 614 Passed, 0 Skipped, 12m 58.12s Total Time

@juan-fernandez juan-fernandez changed the title [test optimization] Add ATR + DI logs [test optimization] Fix ATR + DI Jan 31, 2025
@juan-fernandez juan-fernandez changed the title [test optimization] Fix ATR + DI [test optimization][SDTEST-1355] Fix ATR + DI Jan 31, 2025
@juan-fernandez juan-fernandez marked this pull request as ready for review January 31, 2025 14:42
@juan-fernandez juan-fernandez requested a review from a team as a code owner January 31, 2025 14:42
@juan-fernandez juan-fernandez merged commit 51a58bc into master Feb 3, 2025
352 checks passed
@juan-fernandez juan-fernandez deleted the juan-fernandez/add-extra-logs-to-di branch February 3, 2025 09:45
@rochdev rochdev mentioned this pull request Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants