[github] Workflow to automatically build and push etcd binaries
#4
Conversation
aneesh1
force-pushed
the
aa/github-workflow-dd-build
branch
from
69ae67e
to
e5253e0
Compare
aneesh1
force-pushed
the
aa/github-workflow-dd-build
branch
from
e5253e0
to
93f0ec1
Compare
aneesh1
force-pushed
the
aa/github-workflow-dd-build
branch
from
c961f09
to
e6112fc
Compare
aneesh1
force-pushed
the
aa/github-workflow-dd-build
branch
2 times, most recently
from
0719df3
to
c0ed647
Compare
aneesh1
force-pushed
the
aa/github-workflow-dd-build
branch
from
c0ed647
to
2683d78
Compare
aneesh1
force-pushed
the
aa/github-workflow-dd-build
branch
from
57468ea
to
cecefea
Compare
aneesh1
force-pushed
the
aa/github-workflow-dd-build
branch
from
7e49861
to
a97f6bc
Compare
aneesh1
force-pushed
the
aa/github-workflow-dd-build
branch
from
a9e2f69
to
dc4eff0
Compare
aneesh1
force-pushed
the
aa/github-workflow-dd-build
branch
from
e787af6
to
a3bd987
Compare
| env: | ||
| KUBE_BUILD_PLATFORM: ${{ matrix.platform }} | ||
| - name: Build etcd | ||
| run: REPOSITORY=https://github.com/${{ env.GITHUB_REPOSITORY}}.git ./scripts/build-binary ${{ env.RELEASE_VERSION }} |
There was a problem hiding this comment.
There was another script, ./scripts/release.sh, that I tried to use - it didn't work.
If I supplied a custom tag like RELEASE_VERSION=v3.5.14-dd.16-aneesh-test, it still would look for a branch name like release-3.5. We seem to have a different branch naming scheme and I didn't want to change the code in ./scripts/release.sh, so I found this script instead which builds the binaries for us.
If we're interested in changing our branch naming scheme, we can switch to ./scripts/release.sh in a follow up PR, but for now, this works.
| asset_path: ./_output/release-tars/etcd-${{ env.RELEASE_VERSION }}-${{ matrix.platform }}.${{ matrix.extension }} | ||
| asset_name: etcd-${{ env.RELEASE_VERSION }}-${{ matrix.platform }}.${{ matrix.extension }} | ||
| asset_content_type: application/tar+gzip | ||
| addchecksum: |
There was a problem hiding this comment.
Needed to be separate b/c it relies on the output of the release job and b/c it can't run with strategy.matrix since it'll try and upload a file twice (which doesn't work).
There was a problem hiding this comment.
Why not merge both.
Also do we need the checksum file at all ?
Or do we need the checksum file to be named SHA256SUMS ?
There was a problem hiding this comment.
Also do we need the checksum file at all ?
We use it on our ansible playbook (specifically, this function) - I think it'd be good to keep.
I've changed the flow to now be:
- Build everything
- Define the build matrix to attach select artifacts to the release.
aneesh1
force-pushed
the
aa/github-workflow-dd-build
branch
from
dee982f
to
e7d44a6
Compare
Automates building and pushing
etcdbinaries whenever we create a new branch.