-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config_consistency: Enable tests for the python and ruby tracers #3078
Merged
+130
−146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mabdinur
changed the title
config_consistency: Enable all XPassing tests
config_consistency: Enable python XPassing tests
Sep 20, 2024
mabdinur
changed the title
config_consistency: Enable python XPassing tests
config_consistency: Enable XPassing tests
Sep 20, 2024
mabdinur
commented
Sep 20, 2024
mabdinur
commented
Sep 20, 2024
mabdinur
commented
Sep 20, 2024
mabdinur
force-pushed
the
munir/enable-passing-config-tests
branch
from
September 20, 2024 17:39
60a67fd
to
eac24d3
Compare
mabdinur
changed the title
config_consistency: Enable XPassing tests
config_consistency: Enable Passing Config_UnifiedServiceTagging_CustomService tests
Sep 20, 2024
mabdinur
requested review from
lievan and
wconti27
and removed request for
a team
September 20, 2024 17:41
mabdinur
force-pushed
the
munir/enable-passing-config-tests
branch
2 times, most recently
from
October 22, 2024 05:06
8b60920
to
85422ba
Compare
mabdinur
force-pushed
the
munir/enable-passing-config-tests
branch
3 times, most recently
from
October 22, 2024 20:16
5bc62ed
to
4b4a744
Compare
mabdinur
force-pushed
the
munir/enable-passing-config-tests
branch
from
October 22, 2024 20:16
4b4a744
to
2f4c9d1
Compare
mabdinur
commented
Oct 22, 2024
mabdinur
force-pushed
the
munir/enable-passing-config-tests
branch
from
October 23, 2024 22:07
5a06826
to
b64f0cb
Compare
mabdinur
commented
Oct 24, 2024
mabdinur
force-pushed
the
munir/enable-passing-config-tests
branch
from
October 26, 2024 01:49
c85e1e8
to
51dbac5
Compare
mabdinur
commented
Oct 28, 2024
mabdinur
commented
Oct 28, 2024
mabdinur
commented
Oct 28, 2024
mabdinur
commented
Oct 28, 2024
mabdinur
commented
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Changes to server.rb
start_span
endpoint in the ruby parametric app to avoid setting service, resource, and type arguments to an empty string by default. The default values for these arguments MUST be nil.find_span
helper in the ruby parametric app can retrieve spans that are not active. There is not need to only allow parametric endpoints to operate on active spans. This change allows us to test scenarios when the tracing api is used AND DD_TRACE_ENABLED=False.Minor changes (not required)
Workflow
codeowners
file quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>]
, double-check that only<language>
is impacted by the changebuild-XXX-image
label is present