Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config_consistency: Enable tests for the python and ruby tracers #3078

Merged
merged 36 commits into from
Oct 28, 2024

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Sep 19, 2024

Motivation

  • Enables all python and ruby config consistency tests that are XPassing.

Changes to server.rb

  • Updates the start_span endpoint in the ruby parametric app to avoid setting service, resource, and type arguments to an empty string by default. The default values for these arguments MUST be nil.
  • Ensures the find_span helper in the ruby parametric app can retrieve spans that are not active. There is not need to only allow parametric endpoints to operate on active spans. This change allows us to test scenarios when the tracing api is used AND DD_TRACE_ENABLED=False.

Minor changes (not required)

  • Refactors tests in tests/parametric/test_config_consistency.py to improve readability

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@mabdinur mabdinur changed the title config_consistency: Enable all XPassing tests config_consistency: Enable python XPassing tests Sep 20, 2024
@mabdinur mabdinur changed the title config_consistency: Enable python XPassing tests config_consistency: Enable XPassing tests Sep 20, 2024
manifests/nodejs.yml Outdated Show resolved Hide resolved
manifests/php.yml Outdated Show resolved Hide resolved
manifests/nodejs.yml Outdated Show resolved Hide resolved
@mabdinur mabdinur force-pushed the munir/enable-passing-config-tests branch from 60a67fd to eac24d3 Compare September 20, 2024 17:39
@mabdinur mabdinur changed the title config_consistency: Enable XPassing tests config_consistency: Enable Passing Config_UnifiedServiceTagging_CustomService tests Sep 20, 2024
@mabdinur mabdinur marked this pull request as ready for review September 20, 2024 17:41
@mabdinur mabdinur requested review from a team as code owners September 20, 2024 17:41
@mabdinur mabdinur requested review from lievan and wconti27 and removed request for a team September 20, 2024 17:41
@mabdinur mabdinur force-pushed the munir/enable-passing-config-tests branch 2 times, most recently from 8b60920 to 85422ba Compare October 22, 2024 05:06
@mabdinur mabdinur force-pushed the munir/enable-passing-config-tests branch 3 times, most recently from 5bc62ed to 4b4a744 Compare October 22, 2024 20:16
@mabdinur mabdinur force-pushed the munir/enable-passing-config-tests branch from 4b4a744 to 2f4c9d1 Compare October 22, 2024 20:16
@mabdinur mabdinur force-pushed the munir/enable-passing-config-tests branch from 5a06826 to b64f0cb Compare October 23, 2024 22:07
@mabdinur mabdinur marked this pull request as ready for review October 24, 2024 16:08
@mabdinur mabdinur force-pushed the munir/enable-passing-config-tests branch from c85e1e8 to 51dbac5 Compare October 26, 2024 01:49
manifests/python.yml Outdated Show resolved Hide resolved
manifests/python.yml Outdated Show resolved Hide resolved
manifests/python.yml Outdated Show resolved Hide resolved
manifests/ruby.yml Outdated Show resolved Hide resolved
manifests/ruby.yml Outdated Show resolved Hide resolved
@mabdinur mabdinur merged commit 4492a2b into main Oct 28, 2024
453 of 459 checks passed
@mabdinur mabdinur deleted the munir/enable-passing-config-tests branch October 28, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants