Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: baggage weblog tests #3929

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Conversation

rachelyangdog
Copy link
Contributor

Motivation

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@rachelyangdog rachelyangdog requested review from mabdinur and a team as code owners January 29, 2025 18:49
@rachelyangdog rachelyangdog marked this pull request as draft January 29, 2025 18:49

assert self.r.status_code == 200
data = json.loads(self.r.text)
assert "baggage" in data["request_headers"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we assert that the value in the output is unchanged?

Suggested change
assert "baggage" in data["request_headers"]
assert data["request_headers"]["baggage"] == "foo=bar"

@@ -80,6 +80,18 @@ class _Scenarios:
doc="Test W3C trace style",
)

datadog_baggage_propagation = EndToEndScenario(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we re-use the default scenario (no DD_TRACE_PROPAGATION_STYLE configuration) instead of adding a new scenario? We should re-use scenarios as much as possible because each scenario adds the overhead of running the agent container, weblog containers, and various test proxies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants