-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: baggage weblog tests #3929
base: main
Are you sure you want to change the base?
Conversation
|
||
assert self.r.status_code == 200 | ||
data = json.loads(self.r.text) | ||
assert "baggage" in data["request_headers"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we assert that the value in the output is unchanged?
assert "baggage" in data["request_headers"] | |
assert data["request_headers"]["baggage"] == "foo=bar" |
@@ -80,6 +80,18 @@ class _Scenarios: | |||
doc="Test W3C trace style", | |||
) | |||
|
|||
datadog_baggage_propagation = EndToEndScenario( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we re-use the default scenario (no DD_TRACE_PROPAGATION_STYLE
configuration) instead of adding a new scenario? We should re-use scenarios as much as possible because each scenario adds the overhead of running the agent container, weblog containers, and various test proxies
Motivation
Changes
Workflow
codeowners
file quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>]
, double-check that only<language>
is impacted by the changebuild-XXX-image
label is present