Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CI #17

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Improve CI #17

wants to merge 7 commits into from

Conversation

szepeviktor
Copy link
Contributor

@DaveLiddament This is my default CI.

kép

Problems.

  1. There are no unit tests. As far as I see it is not possible to write unit tests.
  2. Other tools don't need multiple PHP versions.

Separate jobs and steps allow contributors to see where errors occur.

What are your thoughts?

@DaveLiddament
Copy link
Owner

Thanks for this.

There are a few bits I'd like from this.

  • .gitattributes (I really should be adding this to all my projects).
  • The editorconfig is not something I've seen before, looks useful. Thanks for showing it to me. We should use this too.

I'm not sure about the increased complexity of the CI process. Given CI is so quick, both locally and on GH I don't see the value of making it more complex for this project.

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Jan 6, 2023

.gitattributes (I really should be adding this to all my projects).

It controls exported files.

The editorconfig is not something I've seen before, looks useful. Thanks for showing it to me. We should use this too.

It controls all characters of the project.

I'm not sure about the increased complexity of the CI process

Making every check a step in CI makes the UI very easy to read.

kép

@szepeviktor
Copy link
Contributor Author

Reducing my default CI now ... 🏃🏻‍♂️

@szepeviktor szepeviktor marked this pull request as ready for review January 6, 2023 17:31
@szepeviktor
Copy link
Contributor Author

Done 🍏

kép

@MGatner
Copy link

MGatner commented Jan 6, 2024

As a follower of this repo: I appreciate the work but don't find that the enumeration of CI results in the UI adds anything. Maybe if it helps contributors...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants