Skip to content

Commit

Permalink
UPDATE result parser names to indicate they are temporary
Browse files Browse the repository at this point in the history
The full implementations are awaiting on updates to Psalm and PHPStan (relevant issues are referenced).
  • Loading branch information
DaveLiddament committed Dec 20, 2018
1 parent 320c0e4 commit 757b599
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,14 @@ class PhpstanJsonIdentifier implements Identifier
*/
public function getCode(): string
{
return 'phpstan-json';
return 'phpstan-json-tmp';
}

/**
* {@inheritdoc}
*/
public function getDescription(): string
{
return 'PHPStan results (JSON format). To generate use: phpstan analyse --error-format json > <filename>.json';
return 'PHPStan results (JSON format). To generate use: phpstan analyse --error-format json > <filename>.json NOTE: this will be deprecated once this enhancement has been released: https://github.com/phpstan/phpstan/issues/1686';
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,14 @@ class PhpstanTextIdentifier implements Identifier
*/
public function getCode(): string
{
return 'phpstan-text';
return 'phpstan-text-tmp';
}

/**
* {@inheritdoc}
*/
public function getDescription(): string
{
return 'PHPStan results (text format). To generate use: phpstan analyse --error-format raw > <filename>.txt';
return 'PHPStan results (text format). To generate use: phpstan analyse --error-format raw > <filename>.txt NOTE: this will be deprecated once this enhancement has been released: https://github.com/phpstan/phpstan/issues/1686';
}
}
4 changes: 2 additions & 2 deletions src/Plugins/PsalmTextResultsParser/PsalmTextIdentifier.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,14 @@ class PsalmTextIdentifier implements Identifier
*/
public function getCode(): string
{
return 'psalm-text';
return 'psalm-text-tmp';
}

/**
* {@inheritdoc}
*/
public function getDescription(): string
{
return 'Psalm results (text format). To generate use: psalm --report=<filename>.txt';
return 'Psalm results (text format). To generate use: psalm --report=<filename>.txt NOTE: this will be deprecated once this PR is released https://github.com/vimeo/psalm/pull/1139';
}
}

0 comments on commit 757b599

Please sign in to comment.