Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved commends in env file. inline commends now work. #5

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

Karl1b
Copy link

@Karl1b Karl1b commented Oct 2, 2024

now inline commends can be used by space and #

will work
API_KEY=thisisanapikey # This is a commend

will work
API_KEY=thisisanapikey #This is a commend

will not work (no space before #)
API_KEY=thisisanapikey# this is a commend

@DeanPDX
Copy link
Owner

DeanPDX commented Oct 2, 2024

I like this @Karl1b. I suppose if we wanted to be REALLY thorough we could also allow escaped values for # like "This is a value that ends with #". But the case where somebody has a value that ends with " #" is probably so few and far between we don't need to worry about it.

@DeanPDX DeanPDX linked an issue Oct 2, 2024 that may be closed by this pull request
@DeanPDX DeanPDX merged commit 35e06d1 into DeanPDX:main Oct 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow in-line comments
2 participants