Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to the joining issue template #84

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

guillemj
Copy link

This PR contains a few improvements to the joining template. From using better terminology when referring to OpenPGP, to improving the security of the signed message.

The signed message should be clear on what exactly is being requested,
more so given that these signed messages are publicly posted, so that
they cannot be used in another context for potentially malicious
purposes.
Even if just an example, let's make it use the ideal defaults.
While GPG is still one of the most prevalent implementations, it is just
one among many. We are dealing here with OpenPGP artifacts, so spell
that out explicitly. This is more relevant now that GnuPG has opted out
of the IETF OpenPGP working group, and will not be implementing future
revisions of the specification.
@guillemj guillemj requested a review from umlaeute February 20, 2025 00:59
Copy link
Contributor

@umlaeute umlaeute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

however, i forgot everything i read about the OpenPGP schism and how that would affect compatibility.
(and I assume that your change is driven by the desire to clarify the instructions, to make it simpler to submit a correctly signed request).

Probably it would be enough to just state that the signature has to be verifiable against the Debian keyring (this would be a good addition anyhow)
DDs should be able to provide the required information without getting too deep into the details of what is the correct implementation.

@guillemj
Copy link
Author

I didn't feel there was a need to go over the OpenPGP schism in the issue message itself, or the reporting from the GitHub action, but using appropriate terms seems important to me, so that we can encourage and support the richer and wider OpenPGP ecosystem. For example I didn't use gpg to sign my own request. :)

I was pondering as well to switch the GnuPG usage in the GitHub action into SOP, but left that out for now, but might come back to that later. :) I think the example signing instruction could also be generalized or extended with say SOP or sq examples, but left that out for now too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants