Skip to content

Commit

Permalink
chore: better explanations of the index changes about to be made
Browse files Browse the repository at this point in the history
  • Loading branch information
@briangershon
briangershon committed May 27, 2024
1 parent 1c1ecae commit 7cc4f2f
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions apps/academy/src/pages/tracks/nft-solidity/5.mdx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -383,10 +383,10 @@ Notice that we are using the `page folder routing` in our app, which give us an
homepage at the root level, in our url will be `htpp://localhost:3000/` by
default.

We'll only make one change to this file. We'll bring in a brand new `<TierNFT>` React component
We'll trim out most of the content in this initial file, and bring in a brand new `<TierNFT>` React component
that will house our main application functionality and will be displayed on the Home page.

Open `frontend/pages/index.tsx` and add these two lines:
Open `frontend/pages/index.tsx`, remove most of the content, and add these two lines:

```tsx
import { TierNFT } from "../components/tiernft";
Expand All @@ -398,7 +398,7 @@ import { TierNFT } from "../components/tiernft";
</main>
```

so your file should look like this:
Your file should look like this:

```tsx
import type { NextPage } from "next";
Expand Down

2 comments on commit 7cc4f2f

@elPiablo
Copy link
Contributor

@elPiablo elPiablo commented on 7cc4f2f May 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @briangershon,
If I may say, it's still a bit clunky (not a great flow of understanding) as to what the learner should pay attention to. My understanding is that you want to highlight what the component is, and update the file to what you give them:

My suggestion would be:

We'll trim out most of the content in this initial file, and bring in a brand new <TierNFT> React component that will house our main application functionality and will be displayed on the Home page.

We'll be able to identify the component in the index.tsx file by the following two lines:

import { TierNFT } from "../components/tiernft";
<main className={styles.main}>
  <TierNFT />
</main>

Open frontend/pages/index.tsx, remove most of the content, and update the file so that it looks like this:
< provide new version of file as you did >

@briangershon
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @elPiablo, I made these changes.

Please sign in to comment.