-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List item support #134
Merged
Merged
List item support #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements support for list items. This is anything with css
display: list-item
, including naturally li's.So far respects
list-style-type:
disc
(naturally in an ul),decimal
(naturally in an ol),lower-alpha
,upper-alpha
,circle
,square
.disclosure-open
disclosure-closed
Handles nested lists.
Note that it breaks out inline_layout_data seperate from the NodeSpecificData enum, as at one point the list item data was implemented as NodeSpecificData too and needed to overlap with inline layout data, until i realised nodes such as input could also be
display: list-item
and so list-items also needed to be broken out. While inline_layout_data could be moved back into NodeSpecificData, I think it makes sense to leave it out, as afaik layout is independent of the tag type, and there will probably still be overlaps.Whats missing so far:
<li>
aren't nested in<ul>
or<ol>
, eg if they're nested in<div>
instead. I can't quite reconcile how the browsers are behaving here, they compute the styling aslist-style-position: outside
but the layout seems to behave as if it'sinside
.Demonstration has been added to
text
example.