Update the sdk bootstrap code to fail fast on clear problems with the lib from alfasim #390
Conversation
| #define LOAD_SDK_PROC_MAP_TYPE(func_name, func_type) {\ | ||
| dlerror();\ | ||
| api->func_name = (func_type)dlsym(api->handle, #func_name);\ | ||
| char *last_error = dlerror(); | ||
| if (last_error != NULL) {\ | ||
| dlclose(api->handle);\ | ||
| api->handle = nullptr;\ | ||
| return SDK_FAILED_TO_LOAD_FUNCTION;\ | ||
| }\ | ||
| } | ||
| #define LOAD_SDK_PROC(func_name) LOAD_SDK_PROC_MAP_TYPE(func_name, func_name ## _func) |
There was a problem hiding this comment.
It is many years since I wrote any macro.
Is this (and the ones in the other bootstrap file) OK?
… lib from alfasim The problems covered in this update: - Can not load the lib (not found or corrupted); - Can not fetch the address of a function from the lib; ASIM-5532
prusse-martin
force-pushed
the
fb-ASIM-5532-move-freeze-hooks-sdk-dll-load-fail-fast
branch
from
389605a to
dbf8d65
Compare
|
|
@prusse-martin ping |
|
IIRC the "cpp wrapper" bootstrap the sdk api in static initialization and the build and packing tools from sdk will try to load the plugin dll in a context where the api can't be bootstrapped causing it to fail. But without this the plugin execution could error out at some point while alfasim is executing the simulation (say with a seemingly random access violation) because bootstrap would fail silently. @nicoddemus It is up to you the future of this. |
|
Can't you work to get this merged? It is already approved, was there anything missing here? |
|
I think it could be merged. @prusse-martin Was there any problem that made you postpone it? |
Yes.
|
The problems covered in this update:
ASIM-5532