Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub issue link filter #81

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Add GitHub issue link filter #81

wants to merge 2 commits into from

Conversation

Ghabry
Copy link
Member

@Ghabry Ghabry commented Jun 30, 2022 •
edited
Loading

Thats a bit rough for now, but it works ;). Please give feedback.

Converts stuff like player#1234 to [#1234](https://github.com/EasyRPG/Player/pulls/1234 "Player: Save game and move route fixes")

Workflow:

  1. Create .cache, then execute make_cache.rb (TODO: Add to Makefile, move to a better subdirectory)
  2. make

TODO:

  • Only generate the cache once. How to trigger regenerations?
  • Unknown issue numbers will crash
  • Will always emit markdown (is there a way to figure out the context (html or md) in filter?
  • Code duplication
  • Maybe merge liblcf and Player datasource and use an additional key?

@Ghabry Ghabry marked this pull request as draft June 30, 2022 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Awaiting rebase enhancement
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ghabry @fdelapena