Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Fix after-prepare hook doesn't check if release build to determine env #1774

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

delaneyb
Copy link

The current after-prepare hook's check to determine what env - 'production' or 'development' - it is building for does not match the check used in the before-checkForChanges hook. Specifically, it does not identify we are performing a production build if the release flag is set, unless env.production or env.prod are specified.

I have also simplified and made sure the way isProdEnv and isStagingEnv are computed is consistent across the two scripts.

@delaneyb delaneyb changed the title Fix/after prepare env release Fix after-prepare hook doesn't check if release build to determine env Jan 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant